Skip to content

mail: add --version #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2024
Merged

mail: add --version #833

merged 2 commits into from
Nov 25, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 23, 2024

  • Declare VERSION_MESSAGE() as done in other scripts which use getopts()
  • It is not necessary to print a splash message when the program starts; displaying the mailbox is enough
  • Printing os in version message is not required (English.pm was only used for $OSNAME which disappears in this patch)
  • The -v option is for toggling debug information, and it doesn't change

@mknos
mail: add --version
0e0ac0b 
* Declare VERSION_MESSAGE() as done in other scripts which use getopts()
* It is not necessary to print a splash message when the program starts
* Printing os in version message is not required (English.pm was only used for $OSNAME which disappears in this patch)
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mail The mail program labels Nov 23, 2024
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:14 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:14 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:14 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:14 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 23, 2024 13:14 — with GitHub Actions Inactive
briandfoy
briandfoy requested changes Nov 23, 2024
View reviewed changes
@briandfoy briandfoy self-assigned this Nov 23, 2024
@briandfoy briandfoy added the Status: changes requested adjust the pull request as noted in comments label Nov 23, 2024
@coveralls
Copy link

coveralls commented Nov 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12000607755

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11992872685: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@mknos
tweak usage string
d370f41 
* Add $Program name variable as done in other scripts
* Prefix usage string with "usage:"
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 24, 2024 23:42 — with GitHub Actions Inactive
@briandfoy briandfoy merged commit b9b9f28 into briandfoy:master Nov 25, 2024
21 of 22 checks passed
@briandfoy
Copy link
Owner

changes: add --version and improve usage message

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 25, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: mail The mail program Status: changes requested adjust the pull request as noted in comments Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy